Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the tokenizer in Text2TextGenerationPipeline #1096

Open
tarekziade opened this issue Dec 12, 2024 · 1 comment
Open

Allow configuring the tokenizer in Text2TextGenerationPipeline #1096

tarekziade opened this issue Dec 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tarekziade
Copy link

Feature request

The current behavior has hardcoded options for the tokenizer https://github.com/huggingface/transformers.js/blob/main/src/pipelines.js#L761-L775

Motivation

It would be nice to stick with the generic pipeline API and be able to pass through custom tokenizer options that are overwriting tokenizer.json

Your contribution

If the idea sounds good I can contribute the patch

@tarekziade tarekziade added the enhancement New feature or request label Dec 12, 2024
@xenova
Copy link
Collaborator

xenova commented Dec 12, 2024

Sure that's a good idea! We can move it up to the kwargs section 👍 (with defaults set accordingly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants