Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FT] Align parameter names in config files and config classes #439

Open
albertvillanova opened this issue Dec 12, 2024 · 1 comment
Open
Assignees
Labels
feature request New feature/request

Comments

@albertvillanova
Copy link
Member

Issue encountered

Currently, the example config files have a parameter named dtype.

When parsing the config file into the config class, this parameter is renamed to model_dtype.

Solution/Feature

Align the name to model_dtype in both config files and config classes.

Context:

In the config files

  • it already exists a model parameter called model_name
  • there are also instance parameters called instance_type and instance_size

This was discussed in:

Possible alternatives

Leave it as it is.

@albertvillanova albertvillanova added the feature request New feature/request label Dec 12, 2024
@clefourrier
Copy link
Member

That works for me if you want to homogeneize the code across the models for this :)

NathanHB pushed a commit that referenced this issue Dec 17, 2024
Implement TGI model config from path:
```python
TGIModelConfig.from_path(model_config_path)
```

Follow-up to:
- #434 

Related to:
- #439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature/request
Projects
None yet
Development

No branches or pull requests

2 participants