-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added first version of custom model. #437
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very nice, exactly what I had in mind!
No big comments on the main PR, but
- you could add your model class in examples.
- you need to update the doc pages to explain how this works
- it would be good to add a small test to our suite for this feature
I'll try to run it this afternoon and if all goes well and you update the doc, we'll be good to go!
Hahaha please also provide an explicit requirements files :) |
The explicit requirement file is only needed for the google translate example, right? Where should I add that? |
google_translate_model_requirements.txt for now, next to the py file |
Great, fixed the things. @clefourrier ready for review again. |
Hi @JoelNiklaus ! Great PR, howveer, just tried it and it does not seem to work. When running:
deps:
|
Hmm, would you mind trying an environment with the requirements in examples/custom_models/google-translate-requirements-freeze.txt? |
@NathanHB I added another custom model example at examples/custom_models/local_mt_model.py |
Enables the evaluation of any system in the user's control. Fixes Issue 430.
Try with
google_translate_model.py