Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FT] The word "pretrained" is required in model_args but not in model_config_path #405

Open
albertvillanova opened this issue Nov 25, 2024 · 1 comment
Open

[FT] The word "pretrained" is required in model_args but not in model_config_path #405

albertvillanova opened this issue Nov 25, 2024 · 1 comment
Assignees
@clefourrier
Labels
feature request New feature/request

Comments

@albertvillanova
Copy link
Member

albertvillanova commented Nov 25, 2024 •
edited
Loading

Issue encountered

We need to pass "pretrained:MODEL_ID" in --model_args, but this is not necessary in --model_config_path? Can we remove it?

Solution/Feature

It should be handled identically in both cases: without the word "pretrained"?

As discussed with @clefourrier.
@albertvillanova albertvillanova added the feature request New feature/request label Nov 25, 2024
@clefourrier clefourrier self-assigned this Nov 25, 2024
@clefourrier
Copy link
Member

More generally, should homogeneize all configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clefourrier clefourrier

Labels
feature request New feature/request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertvillanova @clefourrier