Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record resume error: no reset time #564

Open
1 of 2 tasks
IlIllllll opened this issue Dec 9, 2024 · 1 comment
Open
1 of 2 tasks

record resume error: no reset time #564

IlIllllll opened this issue Dec 9, 2024 · 1 comment

Comments

@IlIllllll
Copy link

IlIllllll commented Dec 9, 2024

System Info

- `lerobot` version: 0.1.0
- Platform: Linux-5.15.0-125-generic-x86_64-with-glibc2.31
- Python version: 3.10.15
- Huggingface_hub version: 0.26.3
- Dataset version: 3.1.0
- Numpy version: 1.26.4
- PyTorch version (GPU?): 2.5.1+cu124 (True)
- Cuda version: 12040
- Using GPU in script?: yes

Information

  • One of the scripts in the examples/ folder of LeRobot
  • My own task or dataset (give details below)

Reproduction

When using the resume parameter, the reset time is skipped when the number of episodes that have been recorded in the dataset is greater than the total number, in this code(control_robot.py 305)

        if not events["stop_recording"] and (
            (dataset.num_episodes < num_episodes - 1) or events["rerecord_episode"]
        ):
            log_say("Reset the environment", play_sounds)
            reset_environment(robot, events, reset_time_s)

because the inital is set as no episodes recorded , in control_robot.py 275

recorded_episodes = 0

Expected behavior

just change recorded_episodes = dataset.num_episodes, and it does no change to normal record

@IlIllllll IlIllllll changed the title record record resume error: no reset time Dec 9, 2024
@Vacuame
Copy link

Vacuame commented Dec 25, 2024

thanks, i didn't even realized it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants