-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove filecheck to enable symlinks #7133
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
The CI is failing, looks like it breaks imagefolder loading. I just checked fsspec internals and maybe instead we can detect symlink by checking if info["type"] == "file" or (info.get("islink") and info["size"]) |
hmm actually |
Does fsspec perhaps allow resolving symlinks? Something like https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolve |
there is if info["type"] == "file" or (info.get("islink") and info.get("destination") and os.path.isfile(info["destination"])) |
I've added a fix which works with some temporary test files locally
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! lgtm :)
Enables streaming from local symlinks #7083
@lhoestq