Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC enable multimodal and tool usage at once for OAI endpoints ? #1543

Open
flozi00 opened this issue Oct 24, 2024 · 0 comments
Open

RFC enable multimodal and tool usage at once for OAI endpoints ? #1543

flozi00 opened this issue Oct 24, 2024 · 0 comments

Comments

@flozi00
Copy link
Contributor

flozi00 commented Oct 24, 2024

https://github.com/huggingface/chat-ui/blob/8ed1691ecff94e07d10dfb2874d3936d293f4842/src/lib/server/endpoints/openai/endpointOai.ts#L191C53-L191C65

Just played around with combining both of this
What do you think about making tool calling only if no image is in conversation ?
Otherwise we need to insert models twice, once for multi modal and once for tool usage.

A quick solution could be just checking if image_url is part in one of the messages and if it is skip the tools check

Just struggled around because the upload file button was there but didnt worked to do something with the uploaded image until checking the code.

@nsarrazin wdyt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant