-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The optimizer is not receiving the FSDP model parameters. #3209
Comments
does it mean that the optimizer actually does not take any parameters to update? So the model parameters won't be updated in the training loop? |
I guess. |
@weixiong-ur have you had the same result as me ? |
a few things:
Can you give a non jupyter notebook-based repr, and if you are sharing a jupyter notebook, for security reasons, please share the notebook in a gist with outputs not as a PDF as I'm hesitant to open these due to security reasons, and it's difficult to copy/paste from them etc |
Not sure if it's related, but users reported an error in PEFT that points in a similar direction. Note that the error is not caused by PEFT, as I could reproduce it without PEFT. From the error message, it seems like the params passed to the optimizer are not consistent with the model parameters. I could resolve the error by downgrading to:
@eljandoubi Maybe you could check if these versions resolve your issue. |
@muellerzr |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Can you check if huggingface/transformers#35212 has solved the issue? If not, could you try if additionally switching off flash attention helps. |
System Info
Information
Tasks
no_trainer
script in theexamples
folder of thetransformers
repo (such asrun_no_trainer_glue.py
)Reproduction
See code in the pdf
fsdp_acc.pdf
Expected behavior
The optimizer has the FSDP model parameters.
The text was updated successfully, but these errors were encountered: