-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check the contents of responseType #14
Comments
Oh, sorry, I just noticed #13 ...I suggest merging it ;) |
@chris-kahn Thanks for confirming. Sorry for the issue - I hope this gets fixed soon. |
@phadej I tested it, maybe @chris-kahn could recheck too? I agree that automatic testing would be nice. But how do you do automatic browser tests in servant right now? |
To clarify: I don't need automatic tests, but something so I can run a command and get a page where I can check things work. See #15 For example |
Ok, makes sense! |
0.9.3 is on Hackage |
I did test that it works, yes. Thanks for fixing it quickly! |
The generated code makes a comparison to see if
xhr.responseType === 'json'
but in my current Chrome, for example, this variable is always set to the empty string.The generated code should only rely on the
content-type
header, and even in the absence of this header I would suggest trying to parse it as json anyway, or at least making it an option.The text was updated successfully, but these errors were encountered: