Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose errors #4

Open
abidlabs opened this issue Dec 20, 2022 · 3 comments
Open

Expose errors #4

abidlabs opened this issue Dec 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@abidlabs
Copy link
Member

Instead of not replying, it would be better if errors were exposed

@abidlabs abidlabs added the enhancement New feature or request label Dec 20, 2022
@SaboniAmine
Copy link

Which level of error would you like to expose ?
For instance, trying to query the stabilityai/stable-diffusion space, I get a gradio internal error :

    serialized_input = block.serialize(inputs[i])
AttributeError: 'Dataset' object has no attribute 'serialize'

But when querying the mirrored abidlabs/images space I might wait a long time to get no answer (understandable, with the current queue), or explicitely get an asyncio.exceptions.CancelledError much sooner.
The second might be caught and sent back to the channel as a timeout, but I don't know if users should be exposed to the first one as is.

@abidlabs
Copy link
Member Author

Good point @SaboniAmine! How did you see the gradio internal error when you tried to query stabilityai/stable-diffusion space?

@abidlabs
Copy link
Member Author

In terms of the second error, I think we should also expose the queue ETA when people first make a request to a particular Space. However, this should probably be a separate issue. Would you like to go ahead and create it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants