-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Data Models For initial entities #2
Comments
Data models in Protobufs v3 for GRPC/GoKit compatibility |
https://github.com/gopheracademy/congo/wiki/System-Entities Reading over the list, how about for Attendees: Attendee
EDIT: Or perhaps, a single "attendee" per conference, shared across multiple events? |
What is being a "member of multiple conferences"? |
WIP of one entity at github.com/bketelsen/congo (see /series/series.go) |
So we don't have to jump around, here is the list of entities |
I was thinking of scratching that, per my last comment (in the edit). To keep it multi-tenanted "conferences", an attendee would only belong to a single conference - not multiples. |
I think it's probably best to keep users assigned at a SERIES level |
Something like this maybe? Then, depending on context, you could just not send the full list of activities or people. For example, when viewing an activity, all message Activity {
required int64 id = 1;
required string name = 2;
repeated Person attendees = 3;
//etc.
}
message Person {
required int64 id = 1;
required string fname = 2;
required string lname = 3;
optional string email = 4;
repeated Activity attending = 5;
//etc.
} |
Or, if you wanted to avoid context switching, omit the message ActivityDetails {
required Activity activity = 1;
repeated Person attendees = 2;
//etc
} |
I like the relational messages better |
so @alaska are you taking the first stab at the entities while @eduncan911 works on the first pass of the router/REST bits? |
I think we should keep the same domain naming conventions.
|
Sure thing. That was only an illustrative example anyway. I'll get a pull request out sometime this evening or tomorrow. |
@bketelsen yep, the first pass will be stubs for whatever we'll want inside |
https://github.com/frab/frab/blob/master/db/schema.rb |
One thing I would call out is making more of the fields optional. (i.e. 'gender' was required in the original and I committed specific changes to our copy to make it optional). It's good as a starter framework. |
No worries there, at least if we're still committed to this protobuf thang. All fields are optional in proto3. "required" and "optional" no longer have any meaning to protobuf. |
I'm guessing protobuf has been abandoned since the messages dir and accompanying files have been removed. Should we close this issue, or continue it forward with the revised scheme? |
let's keep it open, since it isn't protobuf specific. I'm trying goa [1] on for size right now [1] goa.design |
See wiki for initial list of entities.
The text was updated successfully, but these errors were encountered: