You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What happened:
When running the tests the quilkin/test/tests/proxy.rs failed 1 out 5 runs, giving of false positives.
What you expected to happen:
The tests to pass every time (unless code changes are making it fail)
How to reproduce it (as minimally and precisely as possible):
run cargo test --package qt --test proxy #-- --show-output
Anything else we need to know?:
From our investigation it seems like the two tests server and recv_from aren't playing nicely. If server tests are removed then all the tests are passing every time.
From further investigation it seems like the proxy session socket reuse is taking longer than expected to return so it makes the recv_from to fail sometimes. Bumping the timeout from 20 to 100 seems to solve the issue. quilkin/test/tests/proxy.rs:202 -> sb.timeout(20, packet_rx.recv())
(See logs)
Personally, I'm quite happy for larger timeouts in unit tests - it's a failure state, so if it fails in 20ms or 1s, it's really not that much different.
Fast success state is where I would optimise for - so happy to take a PR on this 👍🏻
What happened:
When running the tests the
quilkin/test/tests/proxy.rs
failed 1 out 5 runs, giving of false positives.What you expected to happen:
The tests to pass every time (unless code changes are making it fail)
How to reproduce it (as minimally and precisely as possible):
run
cargo test --package qt --test proxy #-- --show-output
Anything else we need to know?:
From our investigation it seems like the two tests
server
andrecv_from
aren't playing nicely. Ifserver
tests are removed then all the tests are passing every time.From further investigation it seems like the proxy session socket reuse is taking longer than expected to return so it makes the
recv_from
to fail sometimes. Bumping the timeout from 20 to 100 seems to solve the issue.quilkin/test/tests/proxy.rs:202 -> sb.timeout(20, packet_rx.recv())
(See logs)
Environment:
The text was updated successfully, but these errors were encountered: