Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation FBX should reset to the keyframe of the first animation #43

Open
lyuma opened this issue Jun 9, 2023 · 0 comments
Open

Animation FBX should reset to the keyframe of the first animation #43

lyuma opened this issue Jun 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@lyuma
Copy link
Contributor

lyuma commented Jun 9, 2023

Godot version

4.1.dev 2c89516

System information

Windows 10

Issue description

These animation FBX work fine in other engines, but look incorrect in Godot and Blender because the baked Node "Lcl Rotation" values are incorrect / based on the animation rather than the T-pose.

FBX seems to have a convention in which the poses included in the file should be ignored, and the first frame of the first AnimStack object is used instead.

Expected behavior in other engines is for the initial rest pose to be the first frame of the first animation stack object. This can be observed for example in Unity by swapping the order of the AnimStack objects in the ASCII FBX and observing that the humanoid configuration screen no longer puts the model into T-pose by default, when Pose -> Reset is selected.

FBX2glTF uses EvaluateLocalTransform passing the default time of infinite, which ignores animation curves.

Given the possibility that this could break or change existing content, it may make sense to be an optional setting (use first animation keyframe). It may help to do more testing/research on more FBX compatible software.

Steps to reproduce

  1. Open the project
  2. Open the idle / jump / run animation FBX
  3. These converted FBX should be in T-pose so the retargeting system can run, but instead they are in the first frame

Minimal reproduction project

fbx files and project are available in:
kenney_fbx_animations.zip

@fire fire added the bug Something isn't working label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants