Add close_tab keybinding action for macOS
#4395
Open
+80
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just noting this is not true, since we have to also implement it for GTK. But I think there's a PR for that too. Thanks for doing this, I'll review soon! |
liby
changed the title
close_tab keybinding actionclose_tab keybinding action for macOS
Implement `close_tab` keybinding action to close the current tab and all splits within that tab.
liby
force-pushed
the
feature/add-close-tab-keybind
branch
from
a18c576 to
13e89fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a dedicated
close_tabkeybinding action, allowing users to bind specific keys for closing tabs. The implementation:close_tabas a new keybinding actionTesting
demo.mov
Partially resolved #4331