macOS: Tabs are split into windows when using toggle_visibility action

[mitchellh]

Discussed in #4240

^{Originally posted by writes-of-spring December 31, 2024}
With 1.0.1 when running the toggle visibility command a window with tabs are made into multiple windows.

The toggle_visibility command is no longer configuration documentation in case it's no longer a featured option.

[dmehala]

I investigated a bit and the problem is here:

ghostty/macos/Sources/App/macOS/AppDelegate.swift

Lines 696 to 702 in 8f5f432

	for window in NSApp.windows.filter({ $0.windowController is BaseTerminalController }) {
	if isVisible {
	window.orderOut(nil)
	} else {
	window.makeKeyAndOrderFront(nil)
	}
	}

orderOut(_:) has the side effect of removing windows from the tabGroup.

I am no swift expert so take this with a grain of salt. One possible solution could be to save the tabGroup state and restore it before bringing the window to the front