Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No confirmation when closing tab (GTK) #4234

Open
leigholiver opened this issue Dec 31, 2024 · 2 comments · May be fixed by #4235
Open

No confirmation when closing tab (GTK) #4234

leigholiver opened this issue Dec 31, 2024 · 2 comments · May be fixed by #4235
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/linux
Milestone

Comments

@leigholiver
Copy link
Contributor

On the discord this bit of feedback came up from here

8323 # - ghostty has tabs (imitating gnome-terminal); when closing a tab with a
8324 #   running process (e.g., a hung vttest), ghostty does not prompt about the 
8325 #   process to be killed.

On investigation there are two places in the GTK apprt where tabs are directly closed/removed without checking for confirmation/running processes (1, 2)

@leigholiver leigholiver linked a pull request Dec 31, 2024 that will close this issue
@mitchellh mitchellh added os/linux gui GUI or app issue regardless of platform (i.e. Swift, GTK) labels Dec 31, 2024
@mitchellh
Copy link
Contributor

You should create a discussion first but given this was from the terminfo feedback I'll accept it. Thanks

@leigholiver
Copy link
Contributor Author

Apologies!

@mitchellh mitchellh added this to the 1.0.2 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/linux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants