Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: feat: introduce deno cli entrypoint #385

Closed
wants to merge 4 commits into from
Closed

Draft: feat: introduce deno cli entrypoint #385

wants to merge 4 commits into from

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Apr 14, 2022 •
edited
Loading

Plans

  • Phase 1: Create CLI within unity builder
  • Phase 2: move CLI to separate repository and call it from all repos on all CI systems.

Changes

  • Introduce Deno CLI entrypoint, achieved by installing deno using a "composite" type for this action.
  • TBC
  • Fixes Create CLI cli#4

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)
  • Is fully able to run the same functionality, but now through Deno / CLI
  • Works on Windows runners
  • Works on Ubuntu runners
  • Works on Mac OS runners

@github-actions
Copy link

Cat Gif

@webbertakken webbertakken marked this pull request as draft April 14, 2022 23:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #385 (47b25cf) into main (47b25cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 47b25cf differs from pull request most recent head b1a7be5. Consider uploading reports for the commit b1a7be5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     game-ci/unity-builder#385   +/-   ##
=======================================
  Coverage   52.36%   52.36%           
=======================================
  Files          65       65           
  Lines        2049     2049           
  Branches      385      385           
=======================================
  Hits         1073     1073           
  Misses        914      914           
  Partials       62       62

@webbertakken webbertakken force-pushed the cli branch 2 times, most recently from 3586995 to 1483b41 Compare April 15, 2022 00:07
@webbertakken
Copy link
Member Author

I've added this to the Roadmap for v3.0.0

@webbertakken webbertakken self-assigned this May 22, 2022
@webbertakken webbertakken added the enhancement New feature or request label May 22, 2022
@webbertakken webbertakken mentioned this pull request Jun 7, 2022
Closed
46 tasks
@webbertakken
Copy link
Member Author

This is now implemented in #413

@webbertakken webbertakken deleted the cli branch August 7, 2022 23:54
@webbertakken webbertakken mentioned this pull request Sep 1, 2022
Merged
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@webbertakken webbertakken

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create CLI
2 participants
@webbertakken @codecov-commenter