Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build on windows #1228

Open
Doublonmousse opened this issue Sep 21, 2024 · 1 comment · May be fixed by #1282
Open

Cannot build on windows #1228

Doublonmousse opened this issue Sep 21, 2024 · 1 comment · May be fixed by #1282
Labels
dev Development / Build issues Windows This issue happens on MS-Windows

Comments

@Doublonmousse
Copy link
Collaborator

Doublonmousse commented Sep 21, 2024 •
edited
Loading

Describe the bug
Various errors when compiling on Windows, maybe from yet-to-be updated packages on mingw, for now I'm getting errors from poppler-rs

Tracking issue for this: https://gitlab.gnome.org/World/Rust/poppler-rs/-/issues/1

Comes from the version bumps in #1218
@Doublonmousse Doublonmousse added dev Development / Build issues Windows This issue happens on MS-Windows labels Sep 21, 2024
@Doublonmousse
Copy link
Collaborator Author

It's a c_long is not an i64 on windows issue.
Using a patched version of the crates.io package https://github.com/Doublonmousse/poppler-patch will work here (beware of using the gitlab version, doesn't play nice with dependencies as it uses git links to other repos instead)

Doublonmousse added a commit to Doublonmousse/rnote that referenced this issue Sep 28, 2024
@Doublonmousse
use a patched poppler-rs dependency to build on windows
f78aa7e 
To workaround around https://gitlab.gnome.org/World/Rust/poppler-rs/-/issues/1 whilst the issue is not acknowledged/fixed.

Workaround for flxzt#1228
Repository owner deleted a comment Oct 24, 2024
This was referenced Nov 2, 2024
Closed
Draft
@Kreijstal Kreijstal mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Development / Build issues Windows This issue happens on MS-Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround for poppler_rs Doublonmousse/rnote
1 participant
@Doublonmousse