Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable/stop scrolling while drawing #1246

Open
puyral opened this issue Oct 3, 2024 · 2 comments
Open

Option to disable/stop scrolling while drawing #1246

puyral opened this issue Oct 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@puyral
Copy link

puyral commented Oct 3, 2024

Is your feature request related to a problem? Please describe.
When one initiates a scroll (with touch or trackpad) it is possible to start drawing while continuing to scroll. This can be quite annoying when one mistakenly starts to scroll just before writing because of poor palm rejection. It seems that it also applies to inertial scrolling.

Describe the solution you'd like
It would be nice to be able to stop any scrolling when the pen gets near / start drawing.

Describe alternatives you've considered
I've looked into disabling the touchscreen entirely, but it doesn't seem possible either.

Additional context
Palm rejection is a difficult problem (but I must say that I'm amazed how well it works already) this should help sidestep the issue.

@puyral
Copy link
Author

puyral commented Oct 7, 2024

I've been fairly successfull at deactivating touch input on demand: https://github.com/puyral/rnote/tree/add-block-touch

This add a buton on the header (next to the focus mode) that deactivate all touch event (that I couls find) on the canvas. Therefore the app will ignore any incorrect touch input (due to poor palm rejection) while keeping the touch capabilities for the rest of the app.

This is my first time ever modifying a GTK app, so I'm assuming I broke many thing.

@Doublonmousse
Copy link
Collaborator

Pretty similar to #1055.
The code looks pretty good.

A few notes though (maybe open a PR for it, i'll be easier to comment)

main...puyral:rnote:add-block-touch#diff-5a05f1fbb8c3c6082ec6bfadb2b457446578b7af7aa2f1367aafb3730e2b8f31R254
-> bad copy/paste here (wrong name duplicated from above, you're not loading the correct variable here)

main...puyral:rnote:add-block-touch#diff-5a05f1fbb8c3c6082ec6bfadb2b457446578b7af7aa2f1367aafb3730e2b8f31R421
Is changing the propagating phase of the drag gesture not enough ? Is it to stop a canvas drag gesture that's in progress when toggling the option ? (Because of inertial scrolling)

@Doublonmousse Doublonmousse added the enhancement New feature or request label Oct 12, 2024
Repository owner deleted a comment Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@puyral @Doublonmousse and others