Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PDF adjust-document import option to import at view position #1088

Open
Root4222 opened this issue May 2, 2024 · 3 comments · May be fixed by #1239
Open

Improve PDF adjust-document import option to import at view position #1088

Root4222 opened this issue May 2, 2024 · 3 comments · May be fixed by #1239
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Root4222
Copy link

Root4222 commented May 2, 2024

Currently, when Importing a PDF into a document, it either loads as an Image or replaces / covers existing pages.
It would make sense if there was an option to append the PDF at the end of the document / inserted as new pages instead of covering the first few pages.
@flxzt
Copy link
Owner

flxzt commented May 18, 2024

The Pdf import position is dependent on the current viewport, so if you scroll down it should be pasted further down in the document as well. Together with the adjust document import option and the snapping option in the canvas menu it should be relatively easy to align the pages with the document

@flxzt flxzt closed this as completed May 18, 2024
@flxzt flxzt added the discussion General conversation label May 18, 2024
@Root4222
Copy link
Author

I'm using 'countinous vertical' (System language is german, so I have to spitball), and when Importing a PDF using the adjust document setting, it just puts it as the top layer for the first x pages, regardless of viewport position. Importing them without the adjust document option and aligning them manually is possible, but the point of the suggestion is to have rnote do that automatically when using adjust document.

@flxzt
Copy link
Owner

flxzt commented May 25, 2024

Ah I see. Let me reword your request then.

@flxzt flxzt reopened this May 25, 2024
@flxzt flxzt changed the title A Way to append PDFs to a Document Improve PDF adjust-document import option to import at view position May 25, 2024
@flxzt flxzt added enhancement New feature or request good first issue Good for newcomers and removed discussion General conversation labels May 25, 2024
strang3nt pushed a commit to strang3nt/rnote that referenced this issue Sep 29, 2024
Document inserted at viewport when adjust_document is true flxzt#1088
e4ff27f
@strang3nt strang3nt linked a pull request Sep 29, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document inserted at viewport when adjust_document is true #1088 strang3nt/rnote
2 participants
@flxzt @Root4222