Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window title drawn at wrong position if TitleBar is collapsed #970

Closed
carloslubbers opened this issue Sep 10, 2021 · 7 comments
Closed

Window title drawn at wrong position if TitleBar is collapsed #970

carloslubbers opened this issue Sep 10, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@carloslubbers
Copy link
Contributor

While trying to create a start screen where the LeftContent is quite narrow, the application title bar starts to appear in the background.

Example in showcase application when the start screen left content is emptied and the ItemsPanelMinWidth = 0
image

I think that in the RibbonTitleBar.xaml, the IsCollapsed trigger (line 40) should also hide the PART_HeaderHolder.


Environment

  • Fluent.Ribbon 3bce4ef
  • Windows 10 21H1
  • .NET 5
@batzen
Copy link
Member

batzen commented Sep 14, 2021

Will have a look at why it's the way it currently is.

@batzen batzen self-assigned this Sep 14, 2021
@batzen batzen added the Styles label Sep 14, 2021
@carloslubbers
Copy link
Contributor Author

Any updates on this?

@batzen
Copy link
Member

batzen commented Dec 20, 2021

Not yet. Had to finish and release version 9.0 first.

@batzen batzen added this to the 9.0.1 milestone Dec 20, 2021
@batzen
Copy link
Member

batzen commented Dec 24, 2021

So after some consideration, it's not that the title should be hidden but it should respect the set HeaderAlignment instead.
In your case, if you are using the default, it should be Center and thus not look cut-off after my fix.

@batzen batzen changed the title Title bar not fully hidden on start screen Window title drawn at wrong position if TitleBar is collapsed Dec 24, 2021
@batzen batzen closed this as completed in 8f7536e Dec 24, 2021
@carloslubbers
Copy link
Contributor Author

Would it be possible to add a way to hide it completely, or is there one already? Respecting the header alignment can be fine, but for smaller window sizes (or a wide LeftContent) it will still be placed below the LeftContent container and be cut off
image

@batzen
Copy link
Member

batzen commented Dec 25, 2021

I will add HeaderVisibility as a new property on the title bar.
That way you can trigger header hiding yourself.
Would that be a solution for you?

@carloslubbers
Copy link
Contributor Author

That probably sounds OK, I will be able to play around with it in the new year and let you know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants