Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLS compliance #825

Closed
YetAnotherCodeMaker opened this issue Jul 20, 2020 · 4 comments
Closed

CLS compliance #825

YetAnotherCodeMaker opened this issue Jul 20, 2020 · 4 comments
Assignees
@batzen
Labels
Bug 🐞
Milestone
8.0.1

Comments

@YetAnotherCodeMaker
Copy link

Why removing CLS compliance? Isn't it a breaking change?

Environment

  • Fluent.Ribbon 8.0.0
@batzen
Copy link
Member

batzen commented Jul 30, 2020

The major version was increased.
Did this break anything for you?
Being CLS compliant in a WPF library is of no use as the only runtime is .NET / .NET core on Windows.

@batzen batzen self-assigned this Jul 30, 2020
@YetAnotherCodeMaker
Copy link
Author

I’m rather strict when I’m coding, and that’s include writing CLS compliant code. Until now, that wasn’t a problem with Fluent Ribbon and I was surprised by this change. Altogether, adding an attribute to all of my Window classes is not a big issue (just a little disturbing)…

@batzen
Copy link
Member

batzen commented Jul 31, 2020

Will have a look at why i removed it.

@batzen
Copy link
Member

batzen commented Aug 1, 2020

I think i removed it because ControlzEx is not CLS compliant.
Will try to get ControlzEx CLS compliant and the update Fluent.Ribbon to be CLS compliant.

@batzen batzen added this to the Next milestone Sep 19, 2020
@batzen batzen closed this as completed in 43724e1 Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batzen batzen

Labels
Bug 🐞
Projects
None yet
Milestone
8.0.1
Development

No branches or pull requests
2 participants
@batzen @YetAnotherCodeMaker