-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening gallery messes up InRibbonGallery resizing. #789
Comments
Here's a sample project. It can be reproduced with InRibbonGalleries within DataTemplates and without (Button 1 and Button 2). |
Can also reproduce this in the showcase application. Don't know how this slipped through... |
Hi Bastian, I saw that you closed the issue, so I did some testing. The resizing itself seems to be fixed, However, there are still problems with the layouting of items inside the InRibbonGallery. Please see the following screenshots taken from the latest Showcase application: I reduced the width of the window that the eight items of the 2nd grouped gallery is displayed in two rows. Then I just opened the gallery and closed it again. After that, on the 3rd image, the orange item is gone and the scrollbars are disabled. Even worse, when I open the gallery again, the size is completely different and the scrollbars are still disabled. When I now resize the opened gallery, I see that all items are still there. I think the issue should be reopened. All the best, |
I don't know. It looks like I did the same steps as you. I build the code from the development branch of 11 April. I tried with debug builds and release builds of net462 and core. |
I can't open the video, every player i have says it's corrupted... |
Could you try to download the compile showcase application from the appveyor feed to see if that version also has the buggy behavior? |
How can I get the showcase application from appveyor? I added the NuGet feed https://ci.appveyor.com/nuget/fluent-ribbon to my NuGet package manager, but with that I only get Fluent.dll. About my video: You're right I can also not play it with Media Player. VLC media player seems to work. |
You can get it from https://ci.appveyor.com/project/batzen/fluent-ribbon/branch/develop/artifacts |
The problem is still reproducible with the executable downloaded from the link. I tested version Fluent.Ribbon-v7.2.0-alpha0017. I think I found what could make a difference. I changed the windows font scaling from 100% to 125% and then it works OK. With font scaling of 100% the problem is there. I uploaded two new videos one with font scaling 100% and one work 125%. In the 125% version, the gallery items don't disappear, but when opening the first gallery in that group, the popup size seems different. in the 100% version, the problem described earlier is fully reproducible. |
That's very strange. My system runs with 100% scaling all the time. Not being able to reproduce the issue on my machine will make fixing very difficult and you will have to test every iteration i make. Could we chat on gitter or twitter for that? That way i can send you test versions instead of pushing my changes. |
It seems to be a rounding issue. I changed the item width for those two galleries from 50 to 52 as i noticed that "Orange" was cut off at the "e" partially. With that change i am able to reproduce your issue. Will investigate. |
Great. Just send me a new version via Gitter once you have found a solution. |
There is a problem with the resizing of the InRibbonGallery. As long as the gallery is closed, there is no problem. But once it is opened and closed again, the sizing is messed up. See the following screenshots. The gallery is set to MaxItemsInRow="5" and MinItemsInRow="1". For the first screenshot I reduced the width of the window that the number of shown gallery items are reduced to 3. Then I just open and close the gallery.
Open gallery:
Close gallery:
Now more items are shown in the gallery than before and the size of the remaining controls is reduced to adjust the sizing.
This is probably related to issue #765.
The text was updated successfully, but these errors were encountered: