Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox.Height fixed at 22 #755

Closed
mir4colix opened this issue Nov 12, 2019 · 3 comments
Closed

ComboBox.Height fixed at 22 #755

mir4colix opened this issue Nov 12, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@mir4colix
Copy link

Why is the ComboBox Template (ComboBox.xaml) => Grid.Height set to 22?

Sure i can override it with a custom template, but why not set it auto or bind it to the ComboBox.Height ?

Environment

  • Fluent.Ribbon __v7
  • Windows 10
  • .NET Framework 4.7
@batzen
Copy link
Member

batzen commented Dec 1, 2019

Because setting it to auto would cause all kinds of layout issues, as it won't align with all other controls.

Making the ribbon work with Auto for all controls would require a massive amount of work and the result would still have alignment issues for various controls.

@batzen batzen self-assigned this Dec 1, 2019
@batzen batzen closed this as completed Dec 1, 2019
@mir4colix
Copy link
Author

ok. got it.

@batzen
Copy link
Member

batzen commented Dec 2, 2019

I had another look and you are indeed right. The height should be set on the style instead of the template.

@batzen batzen reopened this Dec 2, 2019
@batzen batzen added this to the Next milestone Dec 8, 2019
@batzen batzen closed this as completed in 1aae3b6 Jan 22, 2020
@batzen batzen modified the milestones: Future, 8.0.0 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants