Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added non-generated Colorful.Blue and Colorful.Gray themes #606

Closed
wants to merge 3 commits into from
Closed

Conversation

stylefish
Copy link
Contributor

@stylefish stylefish commented Aug 14, 2018

this adds the two themes "Colorful.Blue" and "Colorful.Gray" inspired by Office 2016 "Colorful" look, see discussion in #578

@batzen
Copy link
Member

batzen commented Sep 2, 2018

@stylefish
Finally had some time to have a look at this and i think i can use the generator, after some enhancements to the generator, to generate these themes too.

May i ask why you introduced WhiteForeColor instead of using Fluent.Ribbon.Colors.IdealForegroundColor?

@stylefish
Copy link
Contributor Author

an excellent question, i think this is a leftover of my first tries... i changed it! :)

@batzen batzen closed this in c55f687 Sep 7, 2018
@batzen
Copy link
Member

batzen commented Sep 7, 2018

The commit pointing to this only contains the changelog changes.
See the generator parameters and the template for details.
Thanks for contributing those themes!!!

As those themes now get generated by the XamlColorSchemeGenerator i couldn't merge your PR.

@batzen batzen self-assigned this Sep 7, 2018
@batzen batzen added this to the 7.0.0 milestone Sep 7, 2018
@batzen batzen added the Styles label Sep 7, 2018
@stylefish stylefish deleted the themes branch September 7, 2018 15:37
@stylefish
Copy link
Contributor Author

yeah no problem! thanks for integrating them into the library! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants