Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backstage animations from BackstageTabControl to Backstage #574

Closed
batzen opened this issue May 29, 2018 · 0 comments
Closed

Move backstage animations from BackstageTabControl to Backstage #574

batzen opened this issue May 29, 2018 · 0 comments

Comments

@batzen
Copy link
Member

batzen commented May 29, 2018

Currently the opening and closing animations are applied to BackstageTabControl which causes performance issue due to the control constantly changing it's size during the animation.

By moving the animations from BackstageTabControl to Backstage we not only improve the performance but also place them were their properties, IsOpenAnimationEnabled and HideAnimationDuration, are attached to.

I consider this a breaking change as the animation resources are moved from BackstageTabControl to Backstage and the animation triggers are moved from xaml to code behind.

Breaking changes:

  • Animation resource names will be moved and renamed
  • IsOpenAnimationEnabled will be renamed to AreAnimationsEnabled
  • HideAnimationDuration will be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant