-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values from DependencyProperties with FrameworkPropertyMetadataOptions.Inherits are not properly inherited from Ribbon to Menu, StartScreen and some other children #428
Comments
There is no Language property on Backstage. Localization, of strings specific to this library, is done through bindings to RibbonLocalization. There were issues regarding DataContext, and thus Bindings, in the Backstage and some other areas which are already fixed in version 6.0 which is currently in development. |
The Language property is inherited from Backstage > RibbonControl > Control > FrameworkElement, but somehow it isn't passed properly through the DependencyObject logical tree. My best guess is that either it is set directly in between or the inheritance chain from the DependencyProperty is disjointed. Snoop shows that on the Adorner Layer its value state is default and not inherited. Edited: Maybe it is already fixed in 6.0 but if not it should have been noted and fixed later on. - also i use this property thats how i found it out. |
Ah, wasn't aware of the Just tested if setting |
Oh, but it only gets the initial value. Changes are not inherited. Will have a look. |
@incureforce Thanks for reporting this as this forced me to rethink my solution for #415 and finally fix the issue in a future proof way instead of fixing it the lazy way. I still have to ask someone at Microsoft why this happens, as it should not have happened initially... |
Thank you, for working on the weekend to fix this. 👍 |
Well, working on the weekend is often the only time i can work on this project. ;-) |
Should be fixed. |
Yes it works as it should. Thank you very much. |
You are welcome. :-) |
The Backstage Control does not detect a Language change in the parent Window (inheritance problem?)
Workaround:
Environment
The text was updated successfully, but these errors were encountered: