Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with contextual tab group #395

Closed
deRightDirection opened this issue Feb 1, 2017 · 14 comments
Closed

issues with contextual tab group #395

deRightDirection opened this issue Feb 1, 2017 · 14 comments
Assignees
Labels
Milestone

Comments

@deRightDirection
Copy link

i discover two issues with my contextual tab group

  1. the tabs which belong to the contextual tab group are not shown till i resize the window
  2. there is a strange red line around the first tab

see attached screenshots and i attached the xaml-code of my ribbon as well

is it also possible to remove the title of the app in the menu?
screenhunter_63 feb 01 10 28
screenhunter_64 feb 01 10 28
screenhunter_65 feb 01 10 28


Environment

  • Fluent.Ribbon __4.0.3.394
  • Theme /Fluent;Component/Themes/Office2013/Generic.xaml
  • Windows 10 anniversary edition
  • .NET Framework 4.6.1


<Application.Resources>

<ResourceDictionary.MergedDictionaries>

<vm:ViewModelLocator x:Key="Locator" />
<converters:BooleanToVisibilityConverter x:Key="booleanVisibilityConverter" />
<converters:BooleanToVisibilityConverter x:Key="inverseBooleanVisibilityConverter" IsReversed="True" />
<converters2:NotNullToVisibilityConverter x:Key="notNullVisibilityConverter" />
<converters2:InverseNullToBooleanConverter x:Key="notNullConverter" />









</ResourceDictionary.MergedDictionaries>

</Application.Resources>


<UserControl.Resources>
<converters:StringToIntConverter x:Key="stringToIntConverter" />
</UserControl.Resources>

<Grid.ColumnDefinitions>


</Grid.ColumnDefinitions>

<Fluent:Ribbon
x:Name="ribbonMenu"
Grid.Column="1"
AutomaticStateManagement="True">
Fluent:Ribbon.Menu
<Fluent:ApplicationMenu Header="File">
Fluent:ApplicationMenu.RightPaneContent









</Fluent:ApplicationMenu.RightPaneContent>
<Fluent:MenuItem Header="New" />
<Fluent:MenuItem Header="Open" />
<Fluent:MenuItem Header="Save As" />

<Fluent:MenuItem
Command="{Binding ExitCommand}"
Header="Exit"
KeyTip="X" />
</Fluent:ApplicationMenu>
</Fluent:Ribbon.Menu>
Fluent:Ribbon.ContextualGroups
<Fluent:RibbonContextualTabGroup
x:Name="layertab"
Background="DarkBlue"
BorderBrush="LightBlue"
Header="Layer"
Visibility="{Binding SelectedLayer, Converter={StaticResource notNullVisibilityConverter}}" />
</Fluent:Ribbon.ContextualGroups>
<Fluent:RibbonTabItem
MinWidth="150"
Header="Data"
IsSelected="True">
<Fluent:RibbonGroupBox Header="datasources">
<Fluent:Button
MinWidth="100"
CanAddToQuickAccessToolBar="False"
Command="{Binding Base.OpenGPXFileCommand}"
CommandParameter="{Binding Map}"
Header="open gpx-file"
SizeDefinition="10"
ToolTip="open gpx-file">
Fluent:Button.LargeIcon
<iconPacks:PackIconMaterial
Width="32"
Height="32"
Foreground="DarkGreen"
Kind="FileImport" />
</Fluent:Button.LargeIcon>
</Fluent:Button>
</Fluent:RibbonGroupBox>
</Fluent:RibbonTabItem>
<Fluent:RibbonTabItem
Group="{Binding ElementName=layertab, Mode=OneWay}"
Header="Properties"
IsSelected="{Binding SelectedLayer, Converter={StaticResource notNullConverter}}"
Visibility="Visible">
<Fluent:RibbonGroupBox MinWidth="150">
<Fluent:TwoLineLabel Text="{Binding SelectedLayer.DisplayName}" />
</Fluent:RibbonGroupBox>
</Fluent:RibbonTabItem>
<Fluent:RibbonTabItem Group="{Binding ElementName=layertab, Mode=OneWay}" Header="Editing">
Fluent:RibbonGroupBox
<Fluent:Button
MinWidth="100"
Command="{Binding Base.FlipDirectionCommand}"
CommandParameter="{Binding DataContext.SelectedLayer}"
Header="flip direction">
Fluent:Button.LargeIcon
<iconPacks:PackIconMaterial
Width="32"
Height="32"
Foreground="DarkGreen"
Kind="Rotate3d" />
</Fluent:Button.LargeIcon>
</Fluent:Button>
</Fluent:RibbonGroupBox>
</Fluent:RibbonTabItem>
<Fluent:RibbonTabItem
MinWidth="150"
Group="{Binding ElementName=layertab, Mode=OneWay}"
Header="Splitting">
Fluent:RibbonGroupBox
<Fluent:Button
MinWidth="100"
Command="{Binding Base.SplitRouteCommand}"
CommandParameter="{Binding DataContext.SelectedLayer}"
Header="split route">
Fluent:Button.LargeIcon
<iconPacks:PackIconMaterial
Width="32"
Height="32"
Foreground="DarkGreen"
Kind="ContentCut" />
</Fluent:Button.LargeIcon>
</Fluent:Button>
<Fluent:Button
MinWidth="100"
Command="{Binding Base.RemoveSplitRouteCommand}"
CommandParameter="{Binding DataContext.SelectedLayer}"
Header="remove split route">
Fluent:Button.LargeIcon
<iconPacks:PackIconMaterial
Width="32"
Height="32"
Foreground="DarkGreen"
Kind="CloseCircle" />
</Fluent:Button.LargeIcon>
</Fluent:Button>
<Fluent:Button
MinWidth="100"
Command="{Binding Base.SaveSplitRouteCommand}"
CommandParameter="{Binding DataContext.SelectedLayer}"
Header="save split route">
Fluent:Button.LargeIcon
<iconPacks:PackIconMaterial
Width="32"
Height="32"
Foreground="DarkGreen"
Kind="ContentSave" />
</Fluent:Button.LargeIcon>
</Fluent:Button>
</Fluent:RibbonGroupBox>
</Fluent:RibbonTabItem>
</Fluent:Ribbon>

@batzen
Copy link
Member

batzen commented Feb 4, 2017

Could try to reproduce this issue using the latest 5.0 preview/prerelease version?
If it's still broken there it would be nice to get a fully working repro attached as a zip file.

@deRightDirection
Copy link
Author

i tried with the 5.0 version but then i get even more issues to build my project

@batzen
Copy link
Member

batzen commented Feb 5, 2017

What kind of issues?
One important thing is that the theme got moved one level up and is no longer Office2013\Generic.xaml but just Generic.xaml instead.

@batzen
Copy link
Member

batzen commented Feb 18, 2017

@MannusEtten Ping

1 similar comment
@batzen
Copy link
Member

batzen commented Mar 10, 2017

@MannusEtten Ping

@batzen batzen added the Waiting for user response 😕 Waiting for the reporter to respond to questions made by maintainer. label Mar 10, 2017
@batzen
Copy link
Member

batzen commented Apr 12, 2017

@MannusEtten Ping

@deRightDirection
Copy link
Author

i tried today again, nothing changed, the contextual tab group titles are not shown

@batzen
Copy link
Member

batzen commented May 12, 2017

You should have added the reference to your OSS project from the start.
There is, of course, no need to provide a repro if your project is OSS.

I cloned your project but i am unable to build it because "GPXDataAnalyzer\GPX" is missing.
Is there any way you can add that project to your repo?

@batzen batzen removed the Waiting for user response 😕 Waiting for the reporter to respond to questions made by maintainer. label May 12, 2017
@deRightDirection
Copy link
Author

the gpx-project is a clone of another OSS-project, i shall add it in a zip to my BikeTouringGIS-project, thanks already for your time and help!

@deRightDirection
Copy link
Author

i added it to the project but clone the 1.1-branch because it is added to this branch

@batzen
Copy link
Member

batzen commented May 17, 2017

Just tried the 1.1 branch but there seem to be a few more projects with relative paths which are missing.
Could you attach a zip archive containing everything i need to build the project?
If that is not possible (i also saw some target files being referenced), it would be nice if you could provide a small repro.

@batzen
Copy link
Member

batzen commented May 20, 2017

I found a way to reproduce your issue.
That's a really strange one.
Will have a look.

@batzen batzen self-assigned this May 20, 2017
@batzen batzen added this to the 6.0.0 milestone May 20, 2017
@batzen batzen closed this as completed in d6bc746 May 20, 2017
@deRightDirection
Copy link
Author

did you fix it in the end? if so, when can i expect a new version so i can release it with my app?
In the repo of my app there is now a zip-file with all sources if you still want to reproduce it.

@batzen
Copy link
Member

batzen commented Jun 3, 2017

@MannusEtten Yes, this was fixed in Fluent.Ribbon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant