Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Office 2013 theme to Generic #302

Closed
batzen opened this issue Apr 14, 2016 · 2 comments
Closed

Rename Office 2013 theme to Generic #302

batzen opened this issue Apr 14, 2016 · 2 comments
Assignees
Milestone

Comments

@batzen
Copy link
Member

batzen commented Apr 14, 2016

As a result of the vote from #282 the Office 2013 theme will be renamed to generic.

This means there should be no trace of the name Office 2013 anymore.

@batzen batzen self-assigned this Apr 14, 2016
@batzen batzen added this to the 5.0.0 milestone Apr 14, 2016
@batzen batzen mentioned this issue Apr 14, 2016
8 tasks
@batzen batzen closed this as completed in d7b9d39 Apr 15, 2016
@maurosampietro
Copy link
Contributor

Not sure it is the right thing to do,
You should reference the Office2013.Xaml from Generic.xaml

The main advantages are that we can still have a self explaining file name for Office2013 theme and you can more easily change the default theme to a new one in the future just by changing the reference to the the resource dictionary inside Generic.xaml file

@batzen
Copy link
Member Author

batzen commented Apr 19, 2016

There won't be different themes anymore. Just different color schemes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants