Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some adaptions to better align with Office 2013 #197

Closed
wants to merge 3 commits into from

Conversation

chrfin
Copy link
Contributor

@chrfin chrfin commented Nov 12, 2015

  • positioning of the text in the screen tip when no image/icon is set
  • background of the split button on hover

@batzen
Copy link
Member

batzen commented Nov 16, 2015

Thanks for contributing.
I will implement the fixes on my own for version 4.0.
The reasons for that are:

  • The colors should be fixed for all buttons as there are no hover borders at all in Office 2013 (didn't ever notice that till you brought this up)
  • The trigger for the icon should be part of ControlTemplate.Triggers (to be consistent with the other triggers)
  • The indentation for your trigger is a bit off

So instead of forcing you to edit your PR I will take your ideas/changes and add them to the code.

Are you ok with that way?

@chrfin
Copy link
Contributor Author

chrfin commented Nov 16, 2015

Are you ok with that way?

Sure, go ahead and take whatever you can use...

@batzen batzen added this to the 3.6.1 milestone Nov 18, 2015
@batzen batzen added the Styles label Nov 18, 2015
@batzen batzen self-assigned this Nov 18, 2015
batzen added a commit that referenced this pull request Nov 18, 2015
@batzen batzen closed this Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants