Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend to remove job folders, simplify interface #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WardBrian
Copy link
Collaborator

Closes #187

This makes two changes:

  1. Rather than serve from the job directory, the compilation step returns the hashed model id, so we can serve from there directly. Now, we can delete the job directory when it's done being used!
  2. Observing that we always create, upload one file, compile, and delete, without any job re-use, we can reasonably collapse all the job endpoints into one. This is mostly useful because it removes a lot of error paths in the code: the user can never provide a non-existent job ID, for example, because they're never given one at all.

This also fixes an issue with the download routes that they were not correctly responding to HEAD requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up job folders after usage is complete
1 participant