Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Caiman and numpy 2.0 #1354

Open
pgunn opened this issue May 18, 2024 · 2 comments
Open

Tracking issue: Caiman and numpy 2.0 #1354

pgunn opened this issue May 18, 2024 · 2 comments

Comments

@pgunn
Copy link
Member

pgunn commented May 18, 2024

numpy 2.0 has release candidates, so a full release is just around the corner.

Right now caiman pins numpy at <2.0.

There's no need to try to test/fix our code before the 2.0 release, but it should be on our radar to adjust our code for 2.0 in the mid-term. Depending on the issues that come up we may:
A) Be able to get along with both versions, or
B) Need to treat this as a gate, doing a minimum version pin after the adjustments

I see both as acceptable, although the former is preferable because we'd be less all-elbows with other packages and user environments.

@kushalkolar
Copy link
Collaborator

numpy v2 just released a few hours ago and is already causing problems elsewhere 🫠 , need to wait for other packages (such as skimage) to make new released compiled against numpy v2

@FlynnOConnell
Copy link

FlynnOConnell commented Nov 26, 2024

Numpy is giving me issues on rigid + nonrigid motion correction:

 line 3153, in motion_correction_piecewise\n    res = dview.map_async(tile_and_correct_wrapper, pars).get(4294967)\n  File "C:\\Users\\RBO\\AppData\\Local\\Programs\\Python\\Python310\\lib\\multiprocessing\\pool.py", line 774, in get\n    raise self._value\nValueError: Unable to avoid copy while creating an array as requested.\nIf using `np.array(obj, copy=False)` replace it with `np.asarray(obj)` to allow a copy when needed (no behavior change in NumPy 1.x).\nFor more details, see https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword.\n'

On numpy==2.0.2, caiman==1.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants