Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Include "npm install" in build steps for GitLab Pages deploy docs #2956

Closed
S4GU4R0 opened this issue Dec 27, 2024 · 1 comment
Closed

Comments

@S4GU4R0
Copy link

S4GU4R0 commented Dec 27, 2024

Request Type

Explanation Improvement (make a description clearer for the reader of the docs)

Description

When trying to deploy to GitLab Pages, I followed these steps very literally, too literally, and didn't realize npm install was assumed. This sent me down an unrelated rabbit hole, since the error it gives is obvious once you realize what happened but less so if you don't realize what happened. I'd like to save someone else the time I spent. Mostly submitting this issue to get permission to add the fix myself really quick. Thanks!

Image

Are you interested in contributing this improvement to the docs?

I'd like to contribute, and I'll open a PR

@archiewood
Copy link
Member

looking at the docs today, this is already included

the install step is npm ci and included above the build step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants