WIP Core logic refactor #182
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split runFinally into success and failure.. and add ability to instrument a trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much Work In Progress and not properly tested yet.. do not merge.
Fixes #150
Fixes #179
What this PR solves / how to test:
This PR is a major rewrite of the core logic.. right now there is a lot of duplication in the individual instrumentations around handling configuration, instrumentation of Env and ExecutionContext etc etc.. But because everything was extremely, but not quite the same, it was hard to abstract out.
But now that we have a few different implementations it became clear how to abstract it properly and that is what this PR is. It greatly reduces the surface areas for subtle bugs like Promise not completing to hide.