Change JSON Parser argument for weather.sh

[jackdeye]

Hi,

I'd like to propose an improvement to __yrno() function in weather.sh. Currently, the argument passed into $jsonparser is incorrect, resulting in the weather not displaying.

Current implementation

In __yrno(), we have

if weather_data=$(curl --max-time 4 -s "https://api.met.no/weatherapi/locationforecast/2.0/compact?lat=${TMUX_POWERLINE_SEG_WEATHER_LAT}&lon=${TMUX_POWERLINE_SEG_WEATHER_LON}"); then
        grep=$TMUX_POWERLINE_SEG_WEATHER_GREP_DEFAULT
	error=$(echo "$weather_data" | $grep -i "error")
	if [ -n "$error" ]; then
		echo "error"
		exit 1
	fi
	jsonparser="${TMUX_POWERLINE_SEG_WEATHER_JSON}"
	degree=$(echo "$weather_data" | $jsonparser -r .properties.timeseries[0].data.instant.details.air_temperature)
	condition=$(echo "$weather_data" | $jsonparser -r .properties.timeseries[0].data.next_1_hours.summary.symbol_code)

This fails because .properties.timeseries[0] is not valid. You can verify this yourself by running the following:
curl --max-time 4 -s "https://api.met.no/weatherapi/locationforecast/2.0/compact?lat=$LAT&lon=$LON" | jq -r .properties.timeseries[0]
with any $LAT and $LON.

Proposed change

Instead, we can do the following:

degree=$(echo "$weather_data" | $jsonparser -r '.properties.timeseries | .[0].data.instant.details.air_temperature') 
condition=$(echo "$weather_data" | $jsonparser -r '.properties.timeseries | .[0].data.next_1_hours.summary.symbol_code')

Verification of Code Validity

I have checked that the code is valid with the following:
curl --max-time 4 -s "https://api.met.no/weatherapi/locationforecast/2.0/compact?lat=$LAT&lon=$LON" | jq -r '.properties.timeseries | .[0].data.instant.details.air_temperature' As this does return the correct temperature.

Request

I’d be happy to submit a Pull Request with the implementation. Let me know your thoughts!

Thanks for considering this suggestion!