fix: improve escaping in yuck #1194
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently, everything has to be escaped twice due to the (extremely outdated)
unescapecrate being run over text after all other processing has already happenedthis pr, when opened, aims to:
unescaper, or find a better solutionAdditional Notes
this might introduce breaking changes, don't know yet.
we should probably evaluate how to best approach this; at the time of opening this pr as a draft, the implementation is very dumb.
i just want to get this idea out there and iterate over it, hopefully improving things in the process
Checklist
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing