Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore][Data] CCS-check must take into account new failure-store delimiter #205109

Open
thomasneirynck opened this issue Dec 23, 2024 · 2 comments
Assignees
Labels
blocker impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0

Comments

@thomasneirynck
Copy link
Contributor

When ES starts to implement the new failure store, CCS checks must not validate index-patterns with failure store delimiters.

The check (

export function isCCSRemoteIndexName(indexExpression: string): boolean {
) should match following change in Elasticsearch (https://github.com/elastic/elasticsearch/pull/118614/files#diff-54b4d10d02244bb6e2b3413b315759f96cc44c6344c59358dabd304dd8def30aR70-R74).

@thomasneirynck thomasneirynck self-assigned this Dec 23, 2024
@thomasneirynck thomasneirynck added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0 labels Dec 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@thomasneirynck
Copy link
Contributor Author

Adding blocker-label, since this needs to be done before 8.18.

@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0
Projects
None yet
Development

No branches or pull requests

3 participants