Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated platform security v1 routes #203915

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Removes deprecated platform security v1 routes #203915

wants to merge 11 commits into from
+293 −430

Conversation

jeramysoucy
Copy link
Contributor

Summary

Removes the v1 routes deprecated in #199656

Part of Kibana 9.0.0 readiness https://github.com/elastic/kibana-team/issues/1190

@jeramysoucy jeramysoucy added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 labels Dec 11, 2024
@jeramysoucy jeramysoucy self-assigned this Dec 11, 2024
@jeramysoucy jeramysoucy marked this pull request as ready for review December 17, 2024 16:59
@jeramysoucy jeramysoucy requested a review from a team as a code owner December 17, 2024 16:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

azasypkin
azasypkin approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a few suggestions.

x-pack/plugins/security/server/routes/authentication/saml.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/saml.ts Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/common.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/common.ts Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 1, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / Common authentication routes login correctly defines route.
  • [job] [logs] Jest Tests #8 / Common authentication routes login correctly defines route.
  • [job] [logs] Jest Tests #8 / Common authentication routes logout correctly defines route.
  • [job] [logs] Jest Tests #8 / Common authentication routes logout correctly defines route.
  • [job] [logs] FTR Configs #6 / Index Management app Index Management: data streams tab Data streams tab Modify data streams index mode allows to downgrade data stream from logsdb to standard index mode
  • [job] [logs] Jest Tests #8 / SAML authentication routes Assertion consumer service endpoint correctly defines route.
  • [job] [logs] Jest Tests #8 / SAML authentication routes Assertion consumer service endpoint correctly defines route.
  • [job] [logs] FTR Configs #79 / security APIs - OIDC (Implicit Flow) OpenID Connect Implicit Flow authentication finishing handshake should return an HTML page that will parse URL fragment
  • [job] [logs] FTR Configs #79 / security APIs - OIDC (Implicit Flow) OpenID Connect Implicit Flow authentication finishing handshake should return an HTML page that will parse URL fragment
  • [job] [logs] FTR Configs #40 / Serverless Common UI - Management Index Management Data Streams Modify data streams index mode allows to downgrade data stream from logsdb to time series index mode

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
security 49 48 -1

History

cc @jeramysoucy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees

@jeramysoucy jeramysoucy

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeramysoucy @elasticmachine @azasypkin