Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON File for Theme #161

Open
32teeth opened this issue Oct 16, 2024 · 5 comments
Open

JSON File for Theme #161

32teeth opened this issue Oct 16, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@32teeth
Copy link
Contributor

32teeth commented Oct 16, 2024

Describe the bug

Although there is a good description in THEMING.json

  • Customers jumping from 1.3 to 1.4 with new theme.json file, no clue what to do.
  • In 1.3 my theme selection and setting was put into the global.json config

global.json

{
  "FontType": 0,
  "Theme": "pixel",
  "Timezone":	"EST+5",
  "Migration": 1390,
  "DispBacklight": 100,
  "Volume": 100,
  "DiskActivity": 1
}

thtme.json

{
}

Tip

Please provide theme.json example with images, or at minimum a mechanism to create on

Having themes in my theme folder produces wonky results

  • GBZ
  • .GBZ
  • Pixel
  • .Pixel

Selecting any root folder in my themes folder doesn't do anything

@32teeth 32teeth added the bug Something isn't working label Oct 16, 2024
@ducalex
Copy link
Owner

ducalex commented Oct 23, 2024

I agree with you, retro-go should have a default/example theme provided as a starting point, so I'll add one.

I'll look into the theme selector issue soon and test it thoroughly, I'll keep you updated.

@32teeth
Copy link
Contributor Author

32teeth commented Oct 28, 2024

That would be awesome. Even a sample template to get me going locally would be helpful

@ducalex
Copy link
Owner

ducalex commented Oct 29, 2024

I'm not having your listing issue, I see my test theme correctly in the menu. I've only tested the dev branch though, it's possible the issue is in a release! There was a typo in one of the launcher's colors that is now fixed.

This is the structure I have:

$ tree /sdcard/retro-go/themes
/sdcard/retro-go/themes
└── test
    └── theme.json

1 directory, 1 file

I'm attaching a zip of the theme I've tested. It's garbage (literally) but it's enough to see that everything seems to be working as intended on my side. test.zip

Soon I'll make a better sample theme to add to the repo and make sure the documentation matches reality!

If you still have the listing issue in the last release or dev branch, maybe you could share the exact commit you're running and also the contents of your retro-go folder (config and themes) so I can replicate?

@32teeth
Copy link
Contributor Author

32teeth commented Nov 1, 2024

Thank you so much. I'll take a look and report back

ducalex added a commit that referenced this issue Dec 8, 2024
Still to do is move the default theme files and values to this new `themes` folder.
ducalex added a commit that referenced this issue Dec 8, 2024
Still to do is move the default theme files and values to this new `themes` folder.
@ducalex
Copy link
Owner

ducalex commented Dec 13, 2024

I've added a themes folder to the project. Currently containing a default folder that can be used as a template to create new themes. I've also updated the instructions to clarify some things, hopefully it helps!

Also if you're willing to contribute/upstream your theme maybe I could start distributing retro-go with more than one built-in theme. And if you do that, we could add a special #define so that targets can specify the default theme to use, so that retro-esp32 builds would use your theme rather than mine, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants