Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package][PySpark] Expose Training and Validation Metrics #11133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[python-package][PySpark] Expose Training and Validation Metrics #11133

wants to merge 3 commits into from
+294 −8

Conversation

ayoub317
Copy link
Contributor

Closes #11132

@ayoub317 ayoub317 force-pushed the expose-metrics branch 9 times, most recently from 3d7161a to 99fc349 Compare December 29, 2024 20:53
wbo4958
wbo4958 reviewed Jan 2, 2025
View reviewed changes
python-package/xgboost/spark/xgboost_training_summary.py Outdated


@dataclass
class _XGBoostTrainingSummary:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be XGBoostTrainingSummary ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

wbo4958
wbo4958 reviewed Jan 2, 2025
View reviewed changes
python-package/xgboost/spark/xgboost_training_summary.py Outdated
@@ -0,0 +1,43 @@
"""Xgboost training summary integration submodule."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about renaming xgboost_training_summary.py to summary.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@wbo4958
Copy link
Contributor

wbo4958 commented Jan 3, 2025

Hi @ayoub317, Could you be able to add some unit tests for this feature?

@ayoub317
Copy link
Contributor Author

ayoub317 commented Jan 3, 2025

Hi @wbo4958,

Yes, with pleasure ! Could you please provide some pointers on where I should define these tests ?

I had a quick look at the test codebase, and I would assume the following:

The tests for the regressor and classifier could be placed under:
xgboost -> tests -> test_distributed -> test_with_spark -> test_spark_local.py -> in the class TestPySparkLocal

The test for the ranker could be placed under:
xgboost -> tests -> test_distributed -> test_with_spark -> test_spark_local.py -> in the class TestPySparkLocalLETOR

Does that sound like a good choice ?

Thanks !

@wbo4958
Copy link
Contributor

wbo4958 commented Jan 3, 2025

The path you pasted should be ok for adding new testing.

@ayoub317 ayoub317 force-pushed the expose-metrics branch 8 times, most recently from 5828a0c to da80def Compare January 4, 2025 23:30
@ayoub317
Copy link
Contributor Author

ayoub317 commented Jan 5, 2025

Thanks @wbo4958 ! I pushed another commit adding the tests. Any feedback is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbo4958 wbo4958 wbo4958 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python-package][PySpark] Expose Training and Validation Metrics
2 participants
@ayoub317 @wbo4958