Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: add support for termination configuration. #1297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

apps: add support for termination configuration. #1297

wants to merge 1 commit into from

Conversation

andrewsomething
Copy link
Member

@loosla
Copy link
Contributor

loosla commented Dec 31, 2024 •
edited
Loading

Looks awesome 🙌
Sorry, looks like we add defaults in schema. Could you add defaults for drain_seconds and grace_period_seconds, please? 🙏

@loosla
Copy link
Contributor

loosla commented Dec 31, 2024

Also, noticed that the instance_count in worker is forced to be updated each time even if it's value hasn't been changed.
Constantly see it in changes on terraform plan.
However, this is not related to Apps Termination feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

digitalocean_app: add termination block (drain_seconds and grace_period_seconds)
2 participants
@andrewsomething @loosla