Load vendor files #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 99.98% 99.55% -0.44%
==========================================
Files 98 99 +1
Lines 5974 6012 +38
==========================================
+ Hits 5973 5985 +12
- Misses 1 27 +26
Continue to review full report at Codecov.
|
…simulator into load_vendor_files
deepanshs
reviewed
Jun 2, 2021
src/mrsimulator/load_vendor_files.py
Outdated
Comment on lines
17
to
18
| coordinates_offset=(str(1 / value["car"]) + " s"), | ||
| origin_offset=(str(1e-6 / value["obs"]) + " s"), |
There was a problem hiding this comment.
replace these lines with
reciprocal={"coordinates_offset": f'{value["car"]} Hz', "origin_offset": f'{value["obs"]} MHz'}
The parameter belong in the reciprocal object.
4 tasks
…simulator into load_vendor_files
- add things to consider.
|
Created a PR to add to_csdm functionality to nmrglue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.