Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixing events to the library method #215

Open
deepanshs opened this issue Jul 20, 2022 · 1 comment
Open

Add mixing events to the library method #215

deepanshs opened this issue Jul 20, 2022 · 1 comment
Assignees
Milestone

Comments

@deepanshs
Copy link
Owner

Add mixing event to 2D library methods.

@deepanshs deepanshs added this to the v0.7 milestone Jul 20, 2022
@deepanshs deepanshs modified the milestones: v0.7, v0.8 Jul 23, 2022
@mgiammar
Copy link
Collaborator

mgiammar commented May 9, 2023

@pjgrandinetti @deepanshs This issue relates to the fact that library 2D methods use the fictitious total mixing between events (pathways all have amplitude of 1) and that total mixing behavior might lead to discrepancies in spectral amplitudes.

Should we work towards adding in explicit MixingEvent objects between events for named methods (e.g. angle of 0 and phase of 0)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants