Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linear interpolation scheme for probability distribution approximation #212

Open
deepanshs opened this issue Jul 19, 2022 · 1 comment
Assignees
Labels
optimization Performance and speed
Milestone

Comments

@deepanshs
Copy link
Owner

Linear interpolation scheme for gridding Czjzek/Extended Czjzek/User-defined distributions.

The current implementation of the probability distribution uses np.histogram2d function to grid 400000 samples (default) over a two-dimensional grid. The histogram function generates a discrete non-continuous distribution which is okay for one-time calculation but is not optimal when used iteratively in a least-squares problem.

Proposed Solution
Use linear interpolation approximation to generate a smooth and continuous probability distribution.

@deepanshs deepanshs added the optimization Performance and speed label Jul 19, 2022
@deepanshs deepanshs added this to the v0.8 milestone Jul 19, 2022
@mgiammar mgiammar self-assigned this Sep 27, 2022
@mgiammar
Copy link
Collaborator

mgiammar commented May 9, 2023

Prototyping for a 2d interpolation scheme has been completed and applied towards least-squares minimization of Czjzek and Extended Czjzek models. Although 2d linear interpolation for random sampling on a grid does make a smoother distribution, the nature of random sampling (even with linear interpolation) makes the chi-squared surface non-analytical and discontinuous.

Regardless, it may be useful to include functions for two- and three-dimensional linear interpolation. @deepanshs I have code written to perform these functions, although it still needs further testing to ensure coverage. Other simulation features should be prioritized over this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Performance and speed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants