Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSRF] CVE-2023-27163 #91

Open
lvitti opened this issue Oct 17, 2023 · 3 comments
Open

[SSRF] CVE-2023-27163 #91

lvitti opened this issue Oct 17, 2023 · 3 comments
Labels
enhancement Requested feature

Comments

@lvitti
Copy link

lvitti commented Oct 17, 2023

Contain a Server-Side Request Forgery (SSRF) via the component /api/baskets/{name}. This vulnerability allows attackers to access network resources and sensitive information via a crafted API request.

https://nvd.nist.gov/vuln/detail/CVE-2023-27163

https://notes.sjtu.edu.cn/s/MUUhEymt7

https://github.com/entr0pie/CVE-2023-27163

@6abc
Copy link

6abc commented Dec 30, 2023

any update on this ?

@ZanyMonk
Copy link

ZanyMonk commented Mar 5, 2024

There's no decent protection for such feature. Even with every single suspicious URL filtered out, one could use a redirection to hit localhost anyways.

If we want to keep such feature (which i do), the only solution is to make it admin-only (ie. enter the master key).
Same could go for the whole "Settings" tab imho.

@darklynx
Copy link
Owner

darklynx commented Mar 6, 2024

Thank you @ZanyMonk , that is true, its quite complicated to implement a protection within a service, its a way easier to sandbox the service itself with a properly defined firewall rules. One of the options: separate project on the cloud provider, another use containers like Docker, LXC, etc with properly isolated network.

This issue was already discussed in this feature request: #79 (comment)

Nevertheless, my plan is to introduce a command line parameter for the service that enables forwarding, so, the feature would be disabled by default. This should at least solve a problem: anyone w/o real understanding of the security implications running Request Baskets service with default settings w/o proper network isolation and therefore opening a back door to their internal network infrastructure.

@darklynx darklynx added the enhancement Requested feature label Mar 6, 2024
McGregsen pushed a commit to McGregsen/request-baskets that referenced this issue Mar 29, 2024
McGregsen pushed a commit to McGregsen/request-baskets that referenced this issue Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requested feature
Projects
None yet
Development

No branches or pull requests

4 participants