Provide the ability to Mock WorkflowActivityContext #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siri-varma It looks like the DCO check failed. Could you please make sure each of your commits are signed? |
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
siri-varma
force-pushed
the
users/svegira/make-context-mockable
branch
from
a0e576f to
f51def0
Compare
|
@siri-varma Looks like we've got several build errors regarding nullability. If you can fix those, I'd appreciate it! |
…xunit.runner.visualstudio, Microsoft.AspNetCore.Mvc.Testing, Moq to the same version in all projects. Signed-off-by: Manuel Menegazzo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…quest Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…d types Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…ality has been moved out to the Dapr.Workflow project instead. Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
This PR takes the implementation of the static method and puts it into the DaprClient instance, pulling from the existing apiTokenHeader on the instance to populate the daprApiToken, pulling the endpoint from the instance's httpEndpoint value and accepting only an appId argument so as to specify the ID of the Dapr app to connect to and place in the resulting URI. --------- Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…irect) (dapr#1366) Migrating whole solution to Central Package Management - several package version upgrades to address security advisories and otherwise. --------- Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Extracting classes out to common project --------- Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Protos pulled out to separate shared project Signed-off-by: Siri Varma Vegiraju <[email protected]>
Add link about Dapr bot to contribution documentation Signed-off-by: Siri Varma Vegiraju <[email protected]>
…rops s headers (dapr#1153) * forward cloudevent props Signed-off-by: Ilias Politsopoulos <[email protected]> * refactor middleware Signed-off-by: Ilias Politsopoulos <[email protected]> * add cloud event property filters Signed-off-by: Ilias Politsopoulos <[email protected]> * update string check Signed-off-by: Ilias Politsopoulos <[email protected]> * forward cloudevent props Signed-off-by: Ilias Politsopoulos <[email protected]> * refactor middleware Signed-off-by: Ilias Politsopoulos <[email protected]> * add cloud event property filters Signed-off-by: Ilias Politsopoulos <[email protected]> * update checks Signed-off-by: Ilias Politsopoulos <[email protected]> --------- Signed-off-by: Whit Waldo <[email protected]> Co-authored-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
* Changed headers, updated introduction to reflect the difference in serialization between either type and added a brief section to detail the use of System.Text.Json for weakly-typed Dapr actor clients and to point to official documentation on it --------- Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…tead of directly (dapr#1363) * Implemented against Dapr.Client.AspNetCore and Dapr.Client Signed-off-by: Whit Waldo <[email protected]> * SImplified DaprWorkflow DI registration and updated to use IConfiguration preference. Needs testing. Signed-off-by: Whit Waldo <[email protected]> * Added missing copyright header Signed-off-by: Whit Waldo <[email protected]> * Updated actor registration to prefer the updated IConfiguration-based approach for pulling the HTTP endpoint and API token Signed-off-by: Whit Waldo <[email protected]> * Adopted accepted proposal's guidelines for favoring different environment variables for determining the sidecar endpoint. Added notes to explain this in the code going forward. Signed-off-by: Whit Waldo <[email protected]> * Made some lines a little more concise, added hostname default to DaprDefaults to use when building endpoints. Signed-off-by: Whit Waldo <[email protected]> * Fixed and updated unit tests Signed-off-by: Whit Waldo <[email protected]> * Updated to put endpoint resolution mechanism in DaprDefaults within Dapr.Common - updating projects and unit tests Signed-off-by: Whit Waldo <[email protected]> * Updated packages to fix security advisory GHSA-447r-wph3-92pm Signed-off-by: Whit Waldo <[email protected]> * Updated Workflow builder to use DaprDefaults with IConfiguration Signed-off-by: Whit Waldo <[email protected]> * Updating global.json Signed-off-by: Whit Waldo <[email protected]> * Tweaked global.json comment Signed-off-by: Whit Waldo <[email protected]> * Adding braces per nit Signed-off-by: Whit Waldo <[email protected]> * Consolidated both registration extension methods to remove duplication Signed-off-by: Whit Waldo <[email protected]> --------- Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
* Removed Serilog nuget from Directory.Packages.props Signed-off-by: Manuel Menegazzo <[email protected]> * Update Directory.Packages.props Signed-off-by: Manuel Menegazzo <[email protected]> --------- Signed-off-by: Manuel Menegazzo <[email protected]> Signed-off-by: Manuel Menegazzo <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…Properties/launchSettings.json Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
siri-varma
force-pushed
the
users/svegira/make-context-mockable
branch
from
3461bc9 to
8f27ba7
Compare
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
siri-varma
force-pushed
the
users/svegira/make-context-mockable
branch
from
7c684dc to
e3e6b0a
Compare
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
…Properties/launchSettings.json Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
siri-varma
force-pushed
the
users/svegira/make-context-mockable
branch
from
f81134b to
ea4ac28
Compare
|
@WhitWaldo let me know if anything else is needed on this PR. Thank you |
WhitWaldo
requested changes
Dec 27, 2024
Signed-off-by: Siri Varma Vegiraju <[email protected]>
WhitWaldo
approved these changes
Dec 28, 2024
|
Thank you very much for your contribution @siri-varma ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the WorkflowActivityContext abstract.
Created DaprWorkflowActivityContext and made it inherit from WorkflowActivityContext
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1200
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: