Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variant fileSchema values #17

Open
jwodder opened this issue Nov 18, 2024 · 1 comment
Open

Support variant fileSchema values #17

jwodder opened this issue Nov 18, 2024 · 1 comment
Labels
enhancement New feature or request therefor generalization Making this useful to other people

Comments

@jwodder
Copy link
Member

jwodder commented Nov 18, 2024

s3invsync currently requires the fileSchema fields in manifest.json files to equal:

"Bucket, Key, VersionId, IsLatest, IsDeleteMarker, Size, LastModifiedDate, ETag, IsMultipartUploaded"

Relax this requirement.

@yarikoptic Do you want/need this for the first working version? It'd be rather tedious to implement.

@jwodder jwodder added enhancement New feature or request therefor generalization Making this useful to other people labels Nov 18, 2024
@yarikoptic
Copy link
Member

I am missing why is it tedious, must be a rust thing since sounds just like loading/constructing a dict and e.g. mapping into dataclass attributes or just using as a dict throughout. But sure -- it is not a priority, but I bet would become needed for anyone to adopt the tool for their bucket inventory with their custom setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request therefor generalization Making this useful to other people
Projects
None yet
Development

No branches or pull requests

2 participants