Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a timeout for outgoing HTTP requests #62

Open
jwodder opened this issue Feb 10, 2024 · 0 comments
Open

Set a timeout for outgoing HTTP requests #62

jwodder opened this issue Feb 10, 2024 · 0 comments
Labels
easy Not hard performance Efficient use of time and space robustness Imperviousness to bad behavior

Comments

@jwodder
Copy link
Member

jwodder commented Feb 10, 2024

A timeout should be set (via reqwest::ClientBuilder::timeout()) on reqwest clients for use when dandidav makes an outgoing HTTP request.

  • Note that this will only affect requests made to Dandi Archive, to datasets.datalad.org, and to S3 when determining a bucket's region. Timeouts for requests made via the S3 SDK will have to be configured separately (assuming they're not already set to something reasonable).

  • For comparison:

  • Errors raised as a result of such timeouts should be converted to 504 responses.

@jwodder jwodder added performance Efficient use of time and space easy Not hard robustness Imperviousness to bad behavior labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Not hard performance Efficient use of time and space robustness Imperviousness to bad behavior
Projects
None yet
Development

No branches or pull requests

1 participant