Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion of presentation] pre-norm transformers #2618

Open
jkpjkpjkp opened this issue Aug 30, 2024 · 0 comments
Open

[suggestion of presentation] pre-norm transformers #2618

jkpjkpjkp opened this issue Aug 30, 2024 · 0 comments

Comments

@jkpjkpjkp
Copy link

the figure&description in transformer.ipynb follows its historical post-norm version. Since (almost?) all modern projects uses pre-norm transformers, maybe it'd be presented head-up, not until in ViT section, to give newbies (like me) an optimized first-impression, and leave the historically significant version to a lesser position.

Thanks! cheers for your great book!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant