Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use Google Fonts CDN #522

Open
dadosch opened this issue Jun 23, 2019 · 0 comments · May be fixed by #523
Open

don't use Google Fonts CDN #522

dadosch opened this issue Jun 23, 2019 · 0 comments · May be fixed by #523

Comments

@dadosch
Copy link

dadosch commented Jun 23, 2019

Expected Behavior

polr should not use google font cdn as you could serve it locally, which makes GDPR compliance much easier for example. There are also already fonts served locally now.

Current Behavior

Currently, this CDN is used by polr/public/css/setup.css.

Possible Solution

The fonts can be included directly, like the case with Fontawesome.
@dadosch dadosch linked a pull request Jun 23, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use local font files instead of google api cdn dadosch/polr
1 participant
@dadosch